Prevent errors when scrolling history

This commit is contained in:
Jeremy Mahieu 2020-04-12 16:24:16 +02:00
parent c7a5a65ed7
commit a318c447ff

View File

@ -477,7 +477,7 @@ weechat.directive('inputBar', function() {
// Arrow up -> go up in history // Arrow up -> go up in history
if ($event.type === "keydown" && code === 38 && document.activeElement === inputNode) { if ($event.type === "keydown" && code === 38 && document.activeElement === inputNode) {
caretPos = inputNode.selectionStart; caretPos = inputNode.selectionStart;
if ($scope.command.slice(0, caretPos).indexOf("\n") !== -1) { if (!$scope.command || $scope.command.slice(0, caretPos).indexOf("\n") !== -1) {
return false; return false;
} }
$scope.command = models.getActiveBuffer().getHistoryUp($scope.command); $scope.command = models.getActiveBuffer().getHistoryUp($scope.command);
@ -494,7 +494,7 @@ weechat.directive('inputBar', function() {
// Arrow down -> go down in history // Arrow down -> go down in history
if ($event.type === "keydown" && code === 40 && document.activeElement === inputNode) { if ($event.type === "keydown" && code === 40 && document.activeElement === inputNode) {
caretPos = inputNode.selectionStart; caretPos = inputNode.selectionStart;
if ($scope.command.slice(caretPos).indexOf("\n") !== -1) { if (!$scope.command || $scope.command.slice(caretPos).indexOf("\n") !== -1) {
return false; return false;
} }
$scope.command = models.getActiveBuffer().getHistoryDown($scope.command); $scope.command = models.getActiveBuffer().getHistoryDown($scope.command);