RAISES when a router import fails - test your domains routers FFS

This commit is contained in:
Maxime Alves LIRMM@home 2020-11-04 17:02:19 +01:00
parent 56657036e4
commit 9516eaa6d7
1 changed files with 4 additions and 3 deletions

View File

@ -136,11 +136,13 @@ def gen_router_routes(m_router: ModuleType, path: List[str]) -> Generator:
subroutes = route_params.get('SUBROUTES', []) subroutes = route_params.get('SUBROUTES', [])
for subroute in subroutes: for subroute in subroutes:
logger.info('Processing subroute **%s** - %s', subroute, m_router.__name__)
path.append(subroute) path.append(subroute)
try: try:
submod = importlib.import_module(f'.{subroute}', m_router.__name__) submod = importlib.import_module(f'.{subroute}', m_router.__name__)
except ImportError: except ImportError as exc:
continue logger.error('Failed to import subroute **{%s}**', subroute)
raise exc
yield from gen_router_routes(submod, path) yield from gen_router_routes(submod, path)
@ -163,7 +165,6 @@ def gen_domain_routes(domain: str, m_dom: ModuleType) -> Generator:
m_router = importlib.import_module('.routers', domain) m_router = importlib.import_module('.routers', domain)
except ImportError: except ImportError:
logger.warning('Domain **%s** has no **routers** module', domain) logger.warning('Domain **%s** has no **routers** module', domain)
logger.debug('%s', m_dom)
m_router = importlib.import_module('.routers', f'.{domain}') m_router = importlib.import_module('.routers', f'.{domain}')
if m_router: if m_router: