From 3d48213834cc0635acf2c57b5d3522583899c855 Mon Sep 17 00:00:00 2001 From: Facetoe Date: Tue, 9 Aug 2016 18:33:35 +0800 Subject: [PATCH] Add test for case where subclass defines a setting and sets it to None --- tests/test_core_modules.py | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/tests/test_core_modules.py b/tests/test_core_modules.py index d3e7982..3d838fe 100644 --- a/tests/test_core_modules.py +++ b/tests/test_core_modules.py @@ -178,6 +178,23 @@ def test_required_defined_raises(): TestRequiredDefined(some_setting='foo') +def test_required_subclass_none_raises(): + """ Ensure required settings defined in subclasses raise a ConfigMissingError if they are set to None""" + + class TestRequiredDefined(Module): + settings = ( + ("some_setting",), + ) + required = ('some_setting',) + + class TestSubClass(TestRequiredDefined): + some_setting = None + + with pytest.raises(ConfigMissingError): + TestRequiredDefined() + TestSubClass(some_setting='foo') + + def test_required_subclass_overide(): """ Ensure required settings defined in subclasses do not raise a ConfigMissingError """