Don't catch exceptions by wildcard randomly

Related #102 #100

i3pystatus/mail/imap.py

@@ -5,6 +5,7 @@ import sys
 import imaplib
 
 from i3pystatus.mail import Backend
+from i3pystatus.core.util import internet
 
 
 class IMAP(Backend):
@@ -34,24 +35,18 @@ class IMAP(Backend):
 
     def get_connection(self):
         if not self.connection:
-            try:
             self.connection = self.imap_class(self.host, self.port)
             self.connection.login(self.username, self.password)
             self.connection.select(self.mailbox)
-            except Exception:
-                self.connection = None
 
-        try:
         self.connection.select(self.mailbox)
-        except Exception:
-            self.connection = None
 
         return self.connection
 
     @property
     def unread(self):
+        if internet():
             conn = self.get_connection()
-        if conn:
             self.last = len(conn.search(None, "UnSeen")[1][0].split())
         return self.last
 

i3pystatus/mpd.py

@@ -47,7 +47,6 @@ class MPD(IntervalModule):
     }
     color = "#FFFFFF"
 
-
     def _mpd_command(self, sock, command):
         try:
             sock.send((command + "\n").encode("utf-8"))
@@ -67,7 +66,6 @@ class MPD(IntervalModule):
             return None
 
     def run(self):
-        try:
         status = self._mpd_command(self.s, "status")
         currentsong = self._mpd_command(self.s, "currentsong")
         fdict = {
@@ -93,9 +91,6 @@ class MPD(IntervalModule):
             "full_text": formatp(self.format, **fdict).strip(),
             "color": self.color,
         }
-        except Exception as e:
-            self.output = {"full_text": "error connecting MPD",
-                           "color": self.color}
 
     def on_leftclick(self):
         try: