From 7dbcec5a09cc8886ad50a5e538fd0548e928ce18 Mon Sep 17 00:00:00 2001 From: Erik Johnson Date: Tue, 27 Sep 2016 09:42:57 -0500 Subject: [PATCH] Updates from code review See https://github.com/enkore/i3pystatus/pull/455#pullrequestreview-1728935 --- i3pystatus/github.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/i3pystatus/github.py b/i3pystatus/github.py index 36a0f57..3e08f6d 100644 --- a/i3pystatus/github.py +++ b/i3pystatus/github.py @@ -362,13 +362,13 @@ class Github(IntervalModule): # event before we completed the initial status check. return - self.notify_status_change() + self.show_status_notification() @staticmethod def notify(message): return DesktopNotification(title='GitHub', body=message).display() - def skip_notify(message): + def skip_notify(self, message): self.logger.debug( 'Desktop notifications turned off. Skipped notification: %s', message @@ -468,7 +468,7 @@ class Github(IntervalModule): return False if not HAS_REQUESTS: - self.log.error( + self.logger.error( 'The requests module is required to check GitHub notifications') self.failed_update = True return False