From c30365338b67a9ad9c64125d7452597b851c9208 Mon Sep 17 00:00:00 2001 From: Facetoe Date: Tue, 9 Aug 2016 18:20:40 +0800 Subject: [PATCH] Refactor conditional to pass required setting tests. If a setting is defined in a subclass and is not None do not raise config error. --- i3pystatus/core/settings.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/i3pystatus/core/settings.py b/i3pystatus/core/settings.py index 4bc1d86..b2d6e3d 100644 --- a/i3pystatus/core/settings.py +++ b/i3pystatus/core/settings.py @@ -33,8 +33,10 @@ class SettingsBaseMeta(type): # required anymore. for base in inspect.getmro(cls): for r in list(required): - if hasattr(base, r) and getattr(base, r) != getattr(cls, r): + if hasattr(base, r) and getattr(base, r) != getattr(cls, r) \ + or hasattr(cls, r) and getattr(cls, r) is not None: required.remove(r) + return unique(settings), required