masq
/
qmk_firmware
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

qmk doctor: Display macOS and Windows versions, and add WSL warning for /mnt (#12441)

This commit is contained in:
Ryan 2021-04-02 21:44:27 +11:00 committed by GitHub
parent ac0ba832c7
commit 12f308748f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
lib/python/qmk/cli/doctor.py
View File

@ -35,6 +35,11 @@ def os_test_linux():
if 'microsoft' in platform.uname().release.lower(): if 'microsoft' in platform.uname().release.lower():
cli.log.info("Detected {fg_cyan}Linux (WSL){fg_reset}.") cli.log.info("Detected {fg_cyan}Linux (WSL){fg_reset}.")
# https://github.com/microsoft/WSL/issues/4197
if QMK_FIRMWARE.startswith("/mnt"):
cli.log.warning("I/O performance on /mnt may be extremely slow.")
return CheckStatus.WARNING
return CheckStatus.OK return CheckStatus.OK
else: else:
cli.log.info("Detected {fg_cyan}Linux{fg_reset}.") cli.log.info("Detected {fg_cyan}Linux{fg_reset}.")
@ -46,7 +51,7 @@ def os_test_linux():
def os_test_macos(): def os_test_macos():
"""Run the Mac specific tests. """Run the Mac specific tests.
""" """
cli.log.info("Detected {fg_cyan}macOS{fg_reset}.") cli.log.info("Detected {fg_cyan}macOS %s{fg_reset}.", platform.mac_ver()[0])
return CheckStatus.OK return CheckStatus.OK
@ -54,7 +59,8 @@ def os_test_macos():
def os_test_windows(): def os_test_windows():
"""Run the Windows specific tests. """Run the Windows specific tests.
""" """
cli.log.info("Detected {fg_cyan}Windows{fg_reset}.") win32_ver = platform.win32_ver()
cli.log.info("Detected {fg_cyan}Windows %s (%s){fg_reset}.", win32_ver[0], win32_ver[1])
return CheckStatus.OK return CheckStatus.OK
@ -71,11 +77,10 @@ def doctor(cli):
* [ ] Compile a trivial program with each compiler * [ ] Compile a trivial program with each compiler
""" """
cli.log.info('QMK Doctor is checking your environment.') cli.log.info('QMK Doctor is checking your environment.')
cli.log.info('QMK home: {fg_cyan}%s', QMK_FIRMWARE)
status = os_tests() status = os_tests()
cli.log.info('QMK home: {fg_cyan}%s', QMK_FIRMWARE)
# Make sure our QMK home is a Git repo # Make sure our QMK home is a Git repo
git_ok = check_git_repo() git_ok = check_git_repo()