diff --git a/keyboards/infinity60/led_controller.c b/keyboards/infinity60/led_controller.c
index d88ae14b15..4dc9b92342 100644
--- a/keyboards/infinity60/led_controller.c
+++ b/keyboards/infinity60/led_controller.c
@@ -25,6 +25,8 @@ along with this program. If not, see .
#include "hal.h"
#include "print.h"
#include "led.h"
+#include "action_layer.h"
+#include "host.h"
#include "led_controller.h"
@@ -70,7 +72,7 @@ along with this program. If not, see .
#define BREATHE_LED_ADDRESS CAPS_LOCK_LED_ADDRESS
#endif
-#define DEBUG_ENABLED 1
+#define DEBUG_ENABLED 0
/* =================
* ChibiOS I2C setup
@@ -172,12 +174,12 @@ static THD_FUNCTION(LEDthread, arg) {
(void)arg;
chRegSetThreadName("LEDthread");
- uint8_t i, j, page;
+ uint8_t i;
uint8_t control_register_word[2] = {0};//2 bytes: register address, byte to write
uint8_t led_control_reg[0x13] = {0};//led control register start address + 0x12 bytes
//persistent status variables
- uint8_t backlight_status, pwm_step_status, page_status;
+ uint8_t pwm_step_status, page_status;
//mailbox variables
uint8_t temp, msg_type, msg_led;
@@ -189,7 +191,6 @@ static THD_FUNCTION(LEDthread, arg) {
*/
// initialize persistent variables
-backlight_status = 0; //start backlight off
pwm_step_status = 4; //full brightness
page_status = 0; //start frame 0 (all off/on)
@@ -202,68 +203,63 @@ page_status = 0; //start frame 0 (all off/on)
msg_led = (msg) & 0xFF; //second byte is action information
xprintf("--------------------\n");
+ chThdSleepMilliseconds(10);
xprintf("mailbox fetch\nmsg: %X\n", msg);
+ chThdSleepMilliseconds(10);
xprintf("type: %X - led: %X\n", msg_type, msg_led);
+ chThdSleepMilliseconds(10);
switch (msg_type){
case KEY_LIGHT:
//TODO: lighting key led on keypress
break;
+ //TODO: custom page that is written using keypresses
+ //TODO: BLINK_ON/OFF_LED
+
case OFF_LED:
//on/off/toggle single led, msg_led = row/col of led
xprintf("OFF_LED\n");
+ chThdSleepMilliseconds(10);
set_led_bit(7, control_register_word, msg_led, 0);
is31_write_data (7, control_register_word, 0x02);
-
- if (page_status < 7) {
- is31_write_register(IS31_FUNCTIONREG, IS31_REG_PICTDISP, 7);
- }
- page_status = 7;
break;
case ON_LED:
xprintf("ON_LED\n");
+ chThdSleepMilliseconds(10);
set_led_bit(7, control_register_word, msg_led, 1);
is31_write_data (7, control_register_word, 0x02);
-
- if (page_status < 7) {//check current led page to prevent double blink
- is31_write_register(IS31_FUNCTIONREG, IS31_REG_PICTDISP, 7);
- }
- page_status = 7;
break;
case TOGGLE_LED:
xprintf("TOGGLE_LED\n");
+ chThdSleepMilliseconds(10);
set_led_bit(7, control_register_word, msg_led, 2);
-
is31_write_data (7, control_register_word, 0x02);
- if (page_status > 7) {
- is31_write_register(IS31_FUNCTIONREG, IS31_REG_PICTDISP, 7);
- }
- page_status = 7;
break;
case TOGGLE_ALL:
xprintf("TOGGLE_ALL\n");
+ chThdSleepMilliseconds(10);
//msg_led = unused
-
is31_read_register(0, 0x00, &temp);//if first byte is on, then toggle frame 0 off
-
led_control_reg[0] = 0;
if (temp==0 || page_status > 0) {
xprintf("all leds on");
+ chThdSleepMilliseconds(10);
__builtin_memcpy(led_control_reg+1, all_on_leds_mask, 0x12);
} else {
xprintf("all leds off");
+ chThdSleepMilliseconds(10);
__builtin_memset(led_control_reg+1, 0, 0x12);
}
-
is31_write_data(0, led_control_reg, 0x13);
+
if (page_status > 0) {
is31_write_register(IS31_FUNCTIONREG, IS31_REG_PICTDISP, 0);
}
-
+
//maintain lock leds
if (host_keyboard_leds() & (1< 90 || led_addr % 10 > 8) {
+ xprintf("Invalid address: %d\n", led_addr);
+ return;
+ }
+
//first byte is led control register address 0x00
//msg_led tens column is pin#, ones column is bit position in 8-bit mask
control_reg_addr = ((led_addr / 10) % 10 - 1 ) * 0x02;// A-register is every other byte
column_bit = 1<<(led_addr % 10 - 1);
- is31_read_register(page,control_reg_addr,&temp);//need to maintain status of leds in this row (1 byte)
+ is31_read_register(page, control_reg_addr, &temp);//maintain status of leds on this byte
column_byte = temp;
switch(action) {
@@ -437,9 +460,11 @@ void set_led_bit (uint8_t page, uint8_t *led_control_reg, uint8_t led_addr, uint
void set_lock_leds(uint8_t lock_type, uint8_t led_on) {
uint8_t page, led_addr, start, temp;
- uint8_t led_control_write[2] = {0};
- //TODO: consolidate control register to top level array vs. three scattered around
+ uint8_t led_control_word[2] = {0};
+ //TODO: this function call could send led address vs lock_type.
+ //however, the switch/case allows for additional steps, like audio, depending on type
+ led_addr = 0;
switch(lock_type) {
case USB_LED_NUM_LOCK:
led_addr = NUM_LOCK_LED_ADDRESS;
@@ -465,16 +490,18 @@ void set_lock_leds(uint8_t lock_type, uint8_t led_on) {
}
//ignore frame0 if all leds are on or if option set in led_controller.h
+ //TODO: blink of all leds are on, clear blink register if not
is31_read_register(0, 0x00, &temp);
- start = (temp>0 || BACKLIGHT_OFF_LOCK_LED_OFF) ? 1 : 0;
+ led_addr += temp == 0 ? 0 : 0x12;//send bit to blink register instead
+ start = BACKLIGHT_OFF_LOCK_LED_OFF ? 1 : 0;
for(page=start; page<8; page++) {
- set_led_bit(page,led_control_write,led_addr,led_on);
- is31_write_data(page, led_control_write, 0x02);
+ set_led_bit(page,led_control_word,led_addr,led_on);
+ is31_write_data(page, led_control_word, 0x02);
}
}
-void write_led_page (uint8_t page, const uint8_t *user_led_array, uint8_t led_count) {
+void write_led_page (uint8_t page, uint8_t *user_led_array, uint8_t led_count) {
uint8_t i;
uint8_t row, col;
uint8_t led_control_register[0x13] = {0};//led control register start address + 0x12 bytes
@@ -516,7 +543,6 @@ void led_controller_init(void) {
//set Display Option Register so all pwm intensity is controlled from Frame 0
is31_write_register(IS31_FUNCTIONREG, IS31_REG_DISPLAYOPT, IS31_REG_DISPLAYOPT_INTENSITY_SAME);
- //TODO: test new init pwm loop
/* set full pwm on Frame 1 */
pwm_register_array[0] = 0;
__builtin_memset(pwm_register_array+1, 0xFF, 8);
diff --git a/keyboards/infinity60/led_controller.h b/keyboards/infinity60/led_controller.h
index 1511004714..b06113b077 100644
--- a/keyboards/infinity60/led_controller.h
+++ b/keyboards/infinity60/led_controller.h
@@ -94,7 +94,7 @@ extern mailbox_t led_mailbox;
void set_led_bit (uint8_t page, uint8_t *led_control_reg, uint8_t led_addr, uint8_t action);
void set_lock_leds (uint8_t lock_type, uint8_t led_on);
-void write_led_page (uint8_t page, const uint8_t *led_array, uint8_t led_count);
+void write_led_page (uint8_t page, uint8_t *led_array, uint8_t led_count);
// constants for signaling the LED controller thread
enum led_msg_t {
@@ -104,7 +104,8 @@ enum led_msg_t {
TOGGLE_LED,
TOGGLE_ALL,
TOGGLE_BACKLIGHT,
- TOGGLE_PAGE_LEDS,
+ DISPLAY_PAGE,
+ RESET_PAGE,
TOGGLE_NUM_LOCK,
TOGGLE_CAPS_LOCK,
MODE_BREATH,