Updates from code review

See https://github.com/enkore/i3pystatus/pull/455#pullrequestreview-1728935
This commit is contained in:
Erik Johnson 2016-09-27 09:42:57 -05:00
parent 598a511420
commit 7dbcec5a09

View File

@ -362,13 +362,13 @@ class Github(IntervalModule):
# event before we completed the initial status check.
return
self.notify_status_change()
self.show_status_notification()
@staticmethod
def notify(message):
return DesktopNotification(title='GitHub', body=message).display()
def skip_notify(message):
def skip_notify(self, message):
self.logger.debug(
'Desktop notifications turned off. Skipped notification: %s',
message
@ -468,7 +468,7 @@ class Github(IntervalModule):
return False
if not HAS_REQUESTS:
self.log.error(
self.logger.error(
'The requests module is required to check GitHub notifications')
self.failed_update = True
return False