Keychron Q11 uses `matrix_mask` to mask away the matrix location used
for `SPLIT_HAND_MATRIX_GRID` (otherwise the keyboard will constantly
generate a wakeup request whenever the host enters suspend). However,
the value of `matrix_mask` is actually chosen to mask away all unused
locations, but it was apparently generated for the ANSI board and
therefore masks away the left Shift key on the ISO board, breaking the
functionality of that key.
Fix `matrix_mask` to make the masking work as intended:
- Set the `[4, 1]` bit to 1; this is the matrix location for the ISO
left Shift.
- Set the `[2, 5]` bit to 0; this is actually the matrix location which
corresponds to `#define SPLIT_HAND_MATRIX_GRID A2, A15` on the left
side, which was intended to be masked; apparently the wakeup problem
does not happen due to `SPLIT_HAND_MATRIX_GRID_LOW_IS_RIGHT`, so the
left half actually has that matrix location open. On the right side
`A2, A15` is `[9, 6]`, which was masked off correctly.
The code for Helix rev3 boards could not be built with, e.g.,
`CONVERT_TO=rp2040_ce` due to invalid `#include <stdio.h>` in the
keyboard level `config.h` (apparently the AVR version of that file
contains guards against usage in assembly code, which was hiding the
bug). Move `#include <stdio.h>` to the C sources which need it.
Co-authored-by: adophoxia <100170946+adophoxia@users.noreply.github.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: wb-joy <chang.li@westberrytech.com>
Co-authored-by: Joy Lee <joylee.lc@foxmail.com>
Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Joel Challis <git@zvecr.com>
* [style] friendly-format info.json
* [chore] remove key labels from info.json
* [chore] correct layout data
Fix a misleading Configurator implementation, and incorrect key sizes
and positioning on the bottom row.
* [chore] re-add key labels to info.json
* Keychron V4 ANSI: rename LAYOUT_ansi_61 to LAYOUT_60_ansi
* Keychron V4 ANSI: enable Community Layout support
* Keychron V4 ISO: correct layout data
Move position [3, 1] up by 0.25u.
* Keychron V4 ISO: rename LAYOUT_iso_62 to LAYOUT_60_iso
* Keychron V4 ISO: enable Community Layout support
* [chore] correct layout data
* [chore] rename LAYOUT to LAYOUT_65_ansi_blocker
Also adds a layout alias so as to not have to edit the user keymaps.
* [enhancement] enable Community Layout support
* [refactor] rename LAYOUT_tkl_ansi to LAYOUT_tkl_f13_ansi
* [enhancement] enable Community Layout support
* [chore] correct layout data
Correct the position of the spacebar.
Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
spbgzh
Brian McKenna
gskygithub
Duncan Sutherland
Ryan
Hugh Rawlinson
3geek14
Synth and Keys
Sergey Vlasov
lalalademaxiya1
Leon Anavi
Álvaro Cortés
Its TLeo
era
harveysch
Nick Brassel
Rico
jonylee@hfd
cole smith
Andrew Kannan
jestercore
yulei
Kumiko as a Service
DUILCHOI
Yak
Danny
peepeetee
Cipulot
jack
フィルターペーパー
James Young
Alfredo Colas Gullon
tan-t
dependabot[bot]
Alabahuy
takashicompany